LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute.html - Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute.html

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix failing test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute.html

diff --git a/LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute.html b/LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute.html

new file mode 100644

index 0000000000000000000000000000000000000000..5aea37b0eaa35c90bdae59850dbad5285e292b92

--- /dev/null

+++ b/LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute.html

@@ -0,0 +1,25 @@

+<!DOCTYPE html>

+<html>

+<body>

+This test checks that if an element has a parent element and the dir attribute

+is not in a defined state (i.e. it is not present or has an invalid value), the

+directionality of the element is the same as the element's parent element's

+directionality.

+<div dir='rtl'>

+ <textarea dir=''>RTL</textarea>

+</div>

+<div dir='rtl'>

+ <textarea dir='invalidDirName'>RTL</textarea>

+</div>

+<div dir='rtl'>

+ <input type='text' dir='' value='RTL'>

+</div>

+<div dir='rtl'>

+ <input type='text' dir='invalidDirName' value='RTL'>

+</div>

+</body>

+</html>

« no previous file with comments | « no previous file | LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute-expected.html » ('j') | Source/core/html/HTMLElement.cpp » ('J')