Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: Source/core/html/HTMLElement.h

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Let style resolver take care of direction Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2007, 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2007, 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE; 74 virtual void accessKeyAction(bool sendMouseEvents) OVERRIDE;
75 75
76 bool ieForbidsInsertHTML() const; 76 bool ieForbidsInsertHTML() const;
77 77
78 virtual HTMLFormElement* formOwner() const { return 0; } 78 virtual HTMLFormElement* formOwner() const { return 0; }
79 79
80 HTMLFormElement* findFormAncestor() const; 80 HTMLFormElement* findFormAncestor() const;
81 81
82 bool hasDirectionAuto() const; 82 bool hasDirectionAuto() const;
83 TextDirection directionalityIfhasDirAutoAttribute(bool& isAuto) const; 83 TextDirection directionalityIfhasDirAutoAttribute(bool& isAuto) const;
84 TextDirection determineDirection() const;
tkent 2014/11/19 03:38:34 Only form controls use this function. So we have
Sunil Ratnu 2014/11/19 05:33:25 The spec says that the directionality of an elemen
tkent 2014/11/19 08:17:29 We should add |virtual AtomicString effectiveDirAt
84 85
85 virtual bool isHTMLUnknownElement() const { return false; } 86 virtual bool isHTMLUnknownElement() const { return false; }
86 virtual bool isPluginElement() const { return false; } 87 virtual bool isPluginElement() const { return false; }
87 88
88 virtual bool isLabelable() const { return false; } 89 virtual bool isLabelable() const { return false; }
89 // http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html #interactive-content 90 // http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html #interactive-content
90 virtual bool isInteractiveContent() const; 91 virtual bool isInteractiveContent() const;
91 virtual void defaultEventHandler(Event*) OVERRIDE; 92 virtual void defaultEventHandler(Event*) OVERRIDE;
92 93
93 static const AtomicString& eventNameForAttributeName(const QualifiedName& at trName); 94 static const AtomicString& eventNameForAttributeName(const QualifiedName& at trName);
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { r eturn is##thisType(node.get()); } \ 175 template<typename T> inline bool is##thisType(const PassRefPtr<T>& node) { r eturn is##thisType(node.get()); } \
175 template<typename T> inline bool is##thisType(const RefPtr<T>& node) { retur n is##thisType(node.get()); } \ 176 template<typename T> inline bool is##thisType(const RefPtr<T>& node) { retur n is##thisType(node.get()); } \
176 template <> inline bool isElementOfType<const thisType>(const HTMLElement& e lement) { return is##thisType(element); } \ 177 template <> inline bool isElementOfType<const thisType>(const HTMLElement& e lement) { return is##thisType(element); } \
177 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 178 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
178 179
179 } // namespace blink 180 } // namespace blink
180 181
181 #include "core/HTMLElementTypeHelpers.h" 182 #include "core/HTMLElementTypeHelpers.h"
182 183
183 #endif // HTMLElement_h 184 #endif // HTMLElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698