Resolve direction correctly when dir attribute is not in a defined state

Source/core/html/HTMLElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 167 matching lines @@
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserModify, CSSValueReadOnly);
     } else if (name == hiddenAttr) {
         addPropertyToPresentationAttributeStyle(style, CSSPropertyDisplay, CSSValueNone);
     } else if (name == draggableAttr) {
         if (equalIgnoringCase(value, "true")) {
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserDrag, CSSValueElement);
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserSelect, CSSValueNone);
         } else if (equalIgnoringCase(value, "false"))
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserDrag, CSSValueNone);
     } else if (name == dirAttr) {
-        if (equalIgnoringCase(value, "auto"))
+        if (equalIgnoringCase(value, "auto")) {
             addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, unicodeBidiAttributeForDirAuto(this));
-        else {
-            if (isValidDirAttribute(value))
+        } else {
+            if (!isValidDirAttribute(value)) {
+                const AtomicString& dirValue = determineDirection() == RTL ? "rtl" : "ltr";

[tkent, 2014/09/10 01:08:52]

I realized that we didn't need to compute direction here.  We should do nothing
if dir= value is invalid, and the style resolver will work well for parent
lookup.

[Sunil Ratnu, 2014/09/10 04:33:00]

Done.

+                addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, dirValue);
+            } else {
                 addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);

[tkent, 2014/09/10 01:08:52]

This can set "auto" to "direction" CSS property.  It's wrong.

[Sunil Ratnu, 2014/09/10 04:33:00]

We don't have this code part now since whenever we encounter an invalid dir
attribute, we do nothing and the style resolver will take care for the parent
lookup.

-            else
-                addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+            }
             if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))
                 addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueEmbed);
         }
     } else if (name.matches(XMLNames::langAttr))
         mapLanguageAttributeToLocale(value, style);
     else if (name == langAttr) {
         // xml:lang has a higher priority than lang.
         if (!fastHasAttribute(XMLNames::langAttr))
             mapLanguageAttributeToLocale(value, style);
     } else
@@ skipping 471 matching lines @@
 {
     if (!(selfOrAncestorHasDirAutoAttribute() && hasDirectionAuto())) {
         isAuto = false;
         return LTR;
     }
 
     isAuto = true;
     return directionality();
 }
 
+// FIXME: Implement directionality for input type='tel' when it is supported
+// [Currently it is not supported in any of the browsers].
+// Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#the-directionality
+TextDirection HTMLElement::determineDirection() const
+{
+    for (const HTMLElement* element = this; element; element = Traversal<HTMLElement>::firstAncestor(*element)) {
+        const AtomicString& dirAttributeValue = element->fastGetAttribute(dirAttr);
+        if (dirAttributeValue.isNull())
+            continue;
+
+        if (equalIgnoringCase(dirAttributeValue, "rtl"))
+            return RTL;
+
+        if (equalIgnoringCase(dirAttributeValue, "ltr"))
+            return LTR;
+
+        if (equalIgnoringCase(dirAttributeValue, "auto")) {
+            bool isAuto;
+            return element->directionalityIfhasDirAutoAttribute(isAuto);
+        }
+    }
+
+    return LTR;
+}
+
+// FIXME: This implementation deviates from the spec in case of 'textarea' having 'auto' attribute.
+// Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#the-directionality
 TextDirection HTMLElement::directionality(Node** strongDirectionalityTextNode) const
 {
     if (isHTMLInputElement(*this)) {
         HTMLInputElement* inputElement = toHTMLInputElement(const_cast<HTMLElement*>(this));
         bool hasStrongDirectionality;
         TextDirection textDirection = determineDirectionality(inputElement->value(), hasStrongDirectionality);
         if (strongDirectionalityTextNode)
             *strongDirectionalityTextNode = hasStrongDirectionality ? inputElement : 0;
         return textDirection;
     }
@@ skipping 298 matching lines @@
 #ifndef NDEBUG
 
 // For use in the debugger
 void dumpInnerHTML(blink::HTMLElement*);
 
 void dumpInnerHTML(blink::HTMLElement* element)
 {
     printf("%s\n", element->innerHTML().ascii().data());
 }
 #endif