LayoutTests/fast/forms/direction-in-case-of-invalid-dir-attribute.html - Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/direction-in-case-of-invalid-dir-attribute.html

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Splitting CL into 2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/forms/direction-in-case-of-invalid-dir-attribute-expected.html » ('j') | LayoutTests/fast/forms/direction-in-case-of-invalid-dir-attribute-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	tkent 2014/09/09 06:37:00 The CL is independent from forms. Probably this t The CL is independent from forms. Probably this test should be in fast/html/. esprehn 2014/09/09 10:20:13 ditto. ditto. Sunil Ratnu 2014/09/09 10:41:57 Done. Show quoted text On 2014/09/09 10:20:13, esprehn wrote: > ditto. Done. Sunil Ratnu 2014/09/09 10:41:57 Done. Show quoted text On 2014/09/09 06:37:00, tkent (overloaded) wrote: > The CL is independent from forms. Probably this test should be in fast/html/. Done.
	2 <body>

	3 This test checks that if an element has a parent element and the dir attribute

	4 is not in a defined state (i.e. it is not present or has an invalid value), the

	5 directionality of the element is the same as the element's parent element's

	6 directionality.

	7 <div dir='rtl'>

	8 <textarea dir=''>RTL</textarea>

	9 </div>

	10

	11 <div dir='rtl'>

	12 <textarea dir='invalidDirName'>RTL</textarea>

	13 </div>

	14

	15 <div dir='rtl'>

	16 <input type='text' dir='' value='RTL'>

	17 </div>

	18

	19 <div dir='rtl'>

	20 <input type='text' dir='invalidDirName' value='RTL'>

	21 </div>

	22

	23 </body>

	24 </html>

OLD	NEW