Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 524583002: Fix safely-roll-deps.py to use single quotes. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
Reviewers:
borenet2, borenet
CC:
chromium-reviews, eseidel, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix safely-roll-deps.py to use single quotes. The regexp were using single quotes but the DEPS files is using single quotes. With this CL, the DEPS file is correctly parsed and updated. BUG=None TBR=eseidel@chromium.org (current LGTM not accepted) Committed: https://crrev.com/59de5c912fe9eac8f3229ec4220f5af38bb2189c Cr-Commit-Position: refs/heads/master@{#292625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/safely-roll-deps.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
mlamouri (slow - plz ping)
mlamouri@chromium.org changed reviewers: + borenet@chromium.org
6 years, 3 months ago (2014-08-29 10:08:13 UTC) #1
mlamouri (slow - plz ping)
Otherwise the script doesn't work. With that fix, it is possible to roll Blink manually ...
6 years, 3 months ago (2014-08-29 10:08:13 UTC) #2
borenet
Code LGTM, but I thought the way forward was to use depot_tools/roll-dep?
6 years, 3 months ago (2014-08-29 12:30:53 UTC) #3
mlamouri (slow - plz ping)
On 2014/08/29 12:30:53, borenet wrote: > Code LGTM, but I thought the way forward was ...
6 years, 3 months ago (2014-08-29 12:45:44 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 3 months ago (2014-08-29 12:45:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/524583002/1
6 years, 3 months ago (2014-08-29 12:46:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 12:46:59 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-29 12:47:00 UTC) #8
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 3 months ago (2014-08-29 12:50:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/524583002/1
6 years, 3 months ago (2014-08-29 12:51:51 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 14:01:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as b5bcf14db76525492abc4f809716d2d6e255dbbd
6 years, 3 months ago (2014-08-29 14:05:57 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59de5c912fe9eac8f3229ec4220f5af38bb2189c
Cr-Commit-Position: refs/heads/master@{#292625}

Powered by Google App Engine
This is Rietveld 408576698