Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 524543002: Removed IDC_PRINT_TO_DESTINATION. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, MAD
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/176ca8f58e7c2d4a26cdf0fa64807b25482a4494 Cr-Commit-Position: refs/heads/master@{#292683}

Patch Set 1 #

Patch Set 2 : Fri Aug 29 11:31:32 PDT 2014 #

Patch Set 3 : Fri Aug 29 14:26:26 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -131 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_manager.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_job_worker.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 4 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/printing/printer_query.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M printing/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D printing/print_destination_interface.h View 1 chunk +0 lines, -32 lines 0 comments Download
D printing/print_destination_none.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + mad@chromium.org, thestig@chromium.org
6 years, 3 months ago (2014-08-29 07:22:54 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-29 07:22:59 UTC) #2
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-29 07:24:50 UTC) #3
Lei Zhang
lgtm unless mad@ has any objections.
6 years, 3 months ago (2014-08-29 07:31:14 UTC) #4
MAD
lgtm
6 years, 3 months ago (2014-08-29 10:05:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/524543002/1
6 years, 3 months ago (2014-08-29 18:01:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/524543002/20001
6 years, 3 months ago (2014-08-29 18:32:33 UTC) #10
Vitaly Buka (NO REVIEWS)
Committed patchset #3 to pending queue manually as 77dd8ea (presubmit successful).
6 years, 3 months ago (2014-08-29 21:31:04 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:33 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/176ca8f58e7c2d4a26cdf0fa64807b25482a4494
Cr-Commit-Position: refs/heads/master@{#292683}

Powered by Google App Engine
This is Rietveld 408576698