[NaCl SDK] Fix a bug in build_version.ChromeVersion()

Committed: https://crrev.com/05f443408180f0cb38f75fb42db18731070fbb5d
Cr-Commit-Position: refs/heads/master@{#292641}

[Sam Clegg, 2014-08-29 11:51:45]

lgtm

https://codereview.chromium.org/524503002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_version.py (right):

https://codereview.chromium.org/524503002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_version.py:115: '''
I think the first line of the docstring should be on the same
line as the opening tripple quote:

"""First line

Long desc
"""

https://codereview.chromium.org/524503002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_version.py:142: return
lastchange.VersionInfo(None, None)
Should we assert / raise here?

[binji, 2014-08-29 16:01:28]

https://codereview.chromium.org/524503002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_version.py (right):

https://codereview.chromium.org/524503002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_version.py:115: '''
On 2014/08/29 11:51:45, Sam Clegg wrote:
> I think the first line of the docstring should be on the same
> line as the opening tripple quote:
> 
> """First line
> 
> Long desc
> """

Done.

https://codereview.chromium.org/524503002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_version.py:142: return
lastchange.VersionInfo(None, None)
On 2014/08/29 11:51:45, Sam Clegg wrote:
> Should we assert / raise here?

Done.

[binji, 2014-08-29 16:03:02]

Committed patchset #2 (id:20001) to pending queue manually as c83b9c9 (presubmit
successful).

[commit-bot: I haz the power, 2014-09-10 03:08:54]

Patchset 2 (id:??) landed as
https://crrev.com/05f443408180f0cb38f75fb42db18731070fbb5d
Cr-Commit-Position: refs/heads/master@{#292641}