Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 524483002: Revert of Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. (Closed)

Created:
6 years, 3 months ago by jvoung (off chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. (patchset #5 of https://codereview.chromium.org/471233003/) Reason for revert: Test is failing on a Blink bot on ChromeOS Original issue's description: > Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. > > Add more checks to test to detect that the resource type of > the URL request is indeed OBJECT. > Would like to get this merged to the M38 branch. > > BUG=401755 > > Committed: https://chromium.googlesource.com/chromium/src/+/bfc3e122d6721ccc93f0f8b19dac4a3c2a0c947d TBR=teravest@chromium.org,ncbray@chromium.org NOTREECHECKS=true NOTRY=true BUG=401755 Committed: https://crrev.com/22bb605b63b7a9fd638fad58c8bc8f985aacd9cd Cr-Commit-Position: refs/heads/master@{#292522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -55 lines) Patch
M chrome/test/nacl/pnacl_header_test.h View 3 chunks +0 lines, -27 lines 0 comments Download
M chrome/test/nacl/pnacl_header_test.cc View 4 chunks +3 lines, -27 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung (off chromium)
Created Revert of Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update.
6 years, 3 months ago (2014-08-29 00:33:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/524483002/1
6 years, 3 months ago (2014-08-29 00:34:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 45f028b0270cc0ce0d2753c35dc3d6ed5fab06e7
6 years, 3 months ago (2014-08-29 00:35:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22bb605b63b7a9fd638fad58c8bc8f985aacd9cd
Cr-Commit-Position: refs/heads/master@{#292522}

Powered by Google App Engine
This is Rietveld 408576698