Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: net/quic/quic_stream_factory.h

Issue 524463004: Adds plumbing for always requiring handshake confirmation in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory.h
diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h
index 6a0216834b2134de505106f48c0c2503465d9382..330f5f53ea803fe0966cd55e42db753e5601b53f 100644
--- a/net/quic/quic_stream_factory.h
+++ b/net/quic/quic_stream_factory.h
@@ -103,6 +103,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
const QuicVersionVector& supported_versions,
bool enable_port_selection,
bool enable_time_based_loss_detection,
+ bool always_require_handshake_confirmation,
const QuicTagVector& connection_options);
virtual ~QuicStreamFactory();
@@ -154,7 +155,9 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
virtual void OnCertAdded(const X509Certificate* cert) OVERRIDE;
virtual void OnCACertChanged(const X509Certificate* cert) OVERRIDE;
- bool require_confirmation() const { return require_confirmation_; }
+ bool require_confirmation() const {
+ return require_confirmation_;
+ }
void set_require_confirmation(bool require_confirmation) {
require_confirmation_ = require_confirmation;
@@ -274,6 +277,10 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
// connection.
bool enable_port_selection_;
+ // Set if we always require handshake confirmation. If true, this will
+ // introduce at least one RTT for the handshake before the client sends data.
+ bool always_require_handshake_confirmation_;
+
// Each profile will (probably) have a unique port_seed_ value. This value is
// used to help seed a pseudo-random number generator (PortSuggester) so that
// we consistently (within this profile) suggest the same ephemeral port when
« no previous file with comments | « net/http/http_network_session.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698