Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2245)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 524463004: Adds plumbing for always requiring handshake confirmation in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More nits fixed, test added, and formatting. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 9cbf7e50612d144c41f7be5106e5125ae370d119..e764b3b0ca8cf4f4449c3718b6f824d2ac982dde 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -320,4 +320,16 @@ TEST_F(IOThreadTest, QuicConnectionOptionsFromDeprecatedFieldTrialParams) {
EXPECT_EQ(options, params.quic_connection_options);
}
+TEST_F(IOThreadTest,
+ QuicAlwaysRequireHandshakeConfirmationFromFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["always_require_handshake_confirmation"] = "true";
+
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ EXPECT_FALSE(params.quic_always_require_handshake_confirmation);
Ryan Hamilton 2014/09/02 19:28:22 I would move this line to the test EnableQuicFromF
Jana 2014/09/02 20:58:15 Done.
+ InitializeNetworkSessionParams(&params);
+ EXPECT_TRUE(params.quic_always_require_handshake_confirmation);
+}
+
} // namespace test

Powered by Google App Engine
This is Rietveld 408576698