Adds plumbing for always requiring handshake confirmation in QUIC.

net/quic/quic_stream_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_STREAM_FACTORY_H_
 #define NET_QUIC_QUIC_STREAM_FACTORY_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 85 matching lines @@
       ChannelIDService* channel_id_service,
       TransportSecurityState* transport_security_state,
       QuicCryptoClientStreamFactory* quic_crypto_client_stream_factory,
       QuicRandom* random_generator,
       QuicClock* clock,
       size_t max_packet_length,
       const std::string& user_agent_id,
       const QuicVersionVector& supported_versions,
       bool enable_port_selection,
       bool enable_time_based_loss_detection,
+      bool always_require_handshake_confirmation,
       const QuicTagVector& connection_options);
   virtual ~QuicStreamFactory();
 
   // Creates a new QuicHttpStream to |host_port_pair| which will be
   // owned by |request|. |is_https| specifies if the protocol is https or not.
   // If a matching session already exists, this method will return OK.  If no
   // matching session exists, this will return ERR_IO_PENDING and will invoke
   // OnRequestComplete asynchronously.
   int Create(const HostPortPair& host_port_pair,
              bool is_https,
@@ skipping 31 matching lines @@
   // Until the servers support roaming, close all connections when the local
   // IP address changes.
   virtual void OnIPAddressChanged() OVERRIDE;
 
   // CertDatabase::Observer methods:
 
   // We close all sessions when certificate database is changed.
   virtual void OnCertAdded(const X509Certificate* cert) OVERRIDE;
   virtual void OnCACertChanged(const X509Certificate* cert) OVERRIDE;
 
-  bool require_confirmation() const { return require_confirmation_; }
+  bool require_confirmation() const {

[Ryan Hamilton, 2014/09/02 19:28:22]

Hm. This method is named in hacker_case which typically means that it's a simple
getter of the similarly named member variable (require_confirmation_). Having it
return the || or two different members is a bit confusing.

+    return require_confirmation_ || always_require_handshake_confirmation_;
+  }
 
   void set_require_confirmation(bool require_confirmation) {
     require_confirmation_ = require_confirmation;
   }
 
   QuicConnectionHelper* helper() { return helper_.get(); }
 
   bool enable_port_selection() const { return enable_port_selection_; }
 
   bool has_quic_server_info_factory() {
@@ skipping 99 matching lines @@
   JobRequestsMap job_requests_map_;
   RequestMap active_requests_;
 
   QuicVersionVector supported_versions_;
 
   // Determine if we should consistently select a client UDP port. If false,
   // then we will just let the OS select a random client port for each new
   // connection.
   bool enable_port_selection_;
 
+  // Set if we always require handshake confirmation. If true, this will
+  // introduce at least one RTT for the handshake before the client sends data.
+  bool always_require_handshake_confirmation_;
+
   // Each profile will (probably) have a unique port_seed_ value.  This value is
   // used to help seed a pseudo-random number generator (PortSuggester) so that
   // we consistently (within this profile) suggest the same ephemeral port when
   // we re-connect to any given server/port.  The differences between profiles
   // (probablistically) prevent two profiles from colliding in their ephemeral
   // port requests.
   uint64 port_seed_;
 
   base::WeakPtrFactory<QuicStreamFactory> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicStreamFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_STREAM_FACTORY_H_