Fix a bug when assign the generation number of indirect objects

core/src/fxcrt/fx_basic_gcc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxcrt/fx_ext.h"
 template <class T, class STR_T>
 T FXSYS_StrToInt(STR_T str)
 {
     FX_BOOL neg = FALSE;
     if (str == NULL) {
         return 0;
     }
     if (*str == '-') {
         neg = TRUE;
         str ++;
     }
     T num = 0;
+    T num_new = 0;
     while (*str) {
         if ((*str) < '0' || (*str) > '9') {
             break;
         }
-        num = num * 10 + (*str) - '0';
+        num_new = num * 10 + (*str) - '0';
+        if (num_new < 0) {
+            break;

[Bo Xu, 2014/09/19 21:48:19]

Now check when the string is too long and overflow the integer.

[Tom Sepez, 2014/09/19 22:15:38]

This can't work, either T is a signed type in which case overflow is undefined,
or T is unsigned in which case overflow is defined but the value will never be
less than 0.

Use the safe math types here if you are worried.

[Bo Xu, 2014/09/19 22:28:15]

Done.

+        }
+        num = num_new;
         str ++;
     }
     return neg ? -num : num;
 }
 template <typename T, typename STR_T>
 STR_T FXSYS_IntToStr(T value, STR_T string, int radix)
 {
     int i = 0;
     if (value < 0) {
         string[i++] = '-';
@@ skipping 188 matching lines @@
             buf[wlen] = bstr[i];
         }
         wlen ++;
     }
     return wlen;
 }
 #ifdef __cplusplus
 }
 #endif
 #endif