Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/dom/templates/html/impl/impl_Event.darttemplate

Issue 52443007: Allow matchingTarget to also include the currentTarget. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/element_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Event.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Event.darttemplate b/tools/dom/templates/html/impl/impl_Event.darttemplate
index ef07e13c1cdca386238aa5b5f3202f5500e8ac03..5dbb17b2e76531d864e9e25e2a41719471b34b45 100644
--- a/tools/dom/templates/html/impl/impl_Event.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Event.darttemplate
@@ -50,7 +50,7 @@ $(ANNOTATIONS)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
var currentTarget = this.currentTarget;
var target = this.target;
var matchedTarget;
- while (matchedTarget == null && target != currentTarget && target != null) {
+ while (matchedTarget == null && target != currentTarget.parent && target != null) {
blois 2013/10/30 23:12:38 why not do the same as matchesWithAncestors: var e
Emily Fortuna 2013/10/30 23:30:20 Same difference. Done.
if (target.matches(_selector)) {
matchedTarget = target;
}
« no previous file with comments | « tests/html/element_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698