Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 52443003: Reland 160869 "Move innerHTML and outerHTML to Element" (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move innerHTML and outerHTML to Element Per the DOM Parsing specification, innerHTML and outerHTML should be available on Element, not HTMLElement. Since HTMLElement and SVGElement are the only interfaces that inherit from Element, the only Web visible difference should be that innerHTML and outerHTML are now available for SVG elements. For <svg>.innerHTML = "<!-- svg elements here -->" to insert elements with correct namespace URI, one adjustment has to be made to the tree builder step of the html parsing algorithm. The changes are described in the spec change <http://html5.org/r/7768>;. The new concept of 'adjustedCurrentNode' is used when processing and when deciding to process foreign content and makes sure that parsed elements go into the correct namespace. Some layout tests that (perhaps accidentally) use innerHTML and outerHTML on SVG elements are adjusted slightly. This is a re-land of 160869 https://codereview.chromium.org/44333002/ BUG=311080 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -79 lines) Patch
A LayoutTests/fast/innerHTML/innerHTML-svg-read.html View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-svg-read-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-svg-write.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-svg-write-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-template-crash.xhtml View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-template-crash-expected.xhtml View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-xml.xhtml View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/innerHTML/innerHTML-xml-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
M LayoutTests/fast/loader/delete-inside-cancelTimer-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/svg/css/script-tests/svg-attribute-length-parsing.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +46 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/markup.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 7 chunks +27 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
davve
The browser test is being disabled in https://codereview.chromium.org/45733012/
7 years, 1 month ago (2013-10-30 14:51:02 UTC) #1
Mike West
rs=me I think carrying over abarth's and pdr's LGTM is fine. Please do copy/paste the ...
7 years, 1 month ago (2013-10-30 20:34:25 UTC) #2
Mike West
On 2013/10/30 20:34:25, Mike West wrote: > rs=me > > I think carrying over abarth's ...
7 years, 1 month ago (2013-10-30 20:35:19 UTC) #3
davve
On 2013/10/30 20:35:19, Mike West wrote: > On 2013/10/30 20:34:25, Mike West wrote: > > ...
7 years, 1 month ago (2013-10-30 20:57:21 UTC) #4
Mike West
On 2013/10/30 20:57:21, davve wrote: > Ok, I fully agree with this. I looked at ...
7 years, 1 month ago (2013-10-30 21:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/52443003/1
7 years, 1 month ago (2013-10-30 21:39:43 UTC) #6
commit-bot: I haz the power
Change committed as 160981
7 years, 1 month ago (2013-10-30 22:58:02 UTC) #7
dglazkov
It still broke browsertests. Please revert. Apologies :-\ http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/32150
7 years, 1 month ago (2013-10-31 01:39:48 UTC) #8
davve
On 2013/10/31 01:39:48, Dimitri Glazkov wrote: > It still broke browsertests. Please revert. Apologies :-\ ...
7 years, 1 month ago (2013-10-31 08:14:36 UTC) #9
yurys
On 2013/10/31 08:14:36, davve wrote: > On 2013/10/31 01:39:48, Dimitri Glazkov wrote: > > It ...
7 years, 1 month ago (2013-10-31 15:20:06 UTC) #10
davve
7 years, 1 month ago (2013-10-31 15:51:58 UTC) #11
Message was sent while issue was closed.
On 2013/10/31 15:20:06, Yury Semikhatsky wrote:

> Blink rev has been rolled to r161048 so it should be fine to rebaseline and
> enable the test.

I've posted https://codereview.chromium.org/54933002/ to address this.

Powered by Google App Engine
This is Rietveld 408576698