Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 524373002: Add mapping of test groups to test driver. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add mapping of test groups to test driver. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23552

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M tools/run-tests.py View 1 3 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-01 09:51:10 UTC) #2
Benedikt Meurer
LGTM with nit https://codereview.chromium.org/524373002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/524373002/diff/1/tools/run-tests.py#newcode77 tools/run-tests.py:77: "libplatform-unittests", Should be: compiler-unittests, heap-unittests, base-unittests, ...
6 years, 3 months ago (2014-09-01 10:29:27 UTC) #3
Michael Achenbach
Done
6 years, 3 months ago (2014-09-01 10:45:59 UTC) #4
Michael Achenbach
6 years, 3 months ago (2014-09-01 10:48:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698