Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 524363003: Changed name of MediaStreamImpl to UserMediaClientImpl. (Closed)

Created:
6 years, 3 months ago by perkj_chrome
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changed name of MediaStreamImpl to UserMediaClientImpl. UserMediaClientImpl's purpose is to implement blink::WebUserMediaClient and does not implement a MediaStream. Thus the class is renamed to reflect this. BUG=409560 Committed: https://crrev.com/1a2d04393635e9ed4d38e064086861563bad02cb Cr-Commit-Position: refs/heads/master@{#293132}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -1868 lines) Patch
M content/content_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_source.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/media/media_stream_impl.h View 1 chunk +0 lines, -253 lines 0 comments Download
D content/renderer/media/media_stream_impl.cc View 1 chunk +0 lines, -953 lines 0 comments Download
D content/renderer/media/media_stream_impl_unittest.cc View 1 chunk +0 lines, -488 lines 0 comments Download
A + content/renderer/media/user_media_client_impl.h View 4 chunks +10 lines, -10 lines 1 comment Download
A + content/renderer/media/user_media_client_impl.cc View 41 chunks +69 lines, -67 lines 1 comment Download
A + content/renderer/media/user_media_client_impl_unittest.cc View 12 chunks +89 lines, -85 lines 1 comment Download
M content/renderer/render_frame_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
perkj_chrome
Can you please review?
6 years, 3 months ago (2014-09-01 12:51:55 UTC) #2
Henrik Grunell
LGTM. Just the copyright test fixes. Thanks for doing this! Make sure you grep for ...
6 years, 3 months ago (2014-09-02 06:47:53 UTC) #3
perkj_chrome
John or Jochen, would you mind taking a look at the render_frame_impl changes? And btw ...
6 years, 3 months ago (2014-09-03 08:45:40 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-03 09:31:11 UTC) #6
perkj_chrome
The internal vote seems to be not to change the copyright year when renaming files. ...
6 years, 3 months ago (2014-09-03 12:47:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/524363003/20001
6 years, 3 months ago (2014-09-03 12:47:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0b986c82121e2d54cc23f5aaa505a123f075a1a8
6 years, 3 months ago (2014-09-03 13:53:50 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a2d04393635e9ed4d38e064086861563bad02cb
Cr-Commit-Position: refs/heads/master@{#293132}

Powered by Google App Engine
This is Rietveld 408576698