Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: content/renderer/pepper/v8object_var.h

Issue 524353002: Remove the unused remnants of NPObject from Pepper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/pepper/npobject_var.cc ('k') | ppapi/shared_impl/var.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_ 5 #ifndef CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_
6 #define CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_ 6 #define CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
12 #include "ppapi/c/pp_instance.h" 12 #include "ppapi/c/pp_instance.h"
13 #include "ppapi/shared_impl/var.h" 13 #include "ppapi/shared_impl/var.h"
14 #include "v8/include/v8.h" 14 #include "v8/include/v8.h"
15 15
16 namespace content { 16 namespace content {
17 class PepperPluginInstanceImpl; 17 class PepperPluginInstanceImpl;
18 } // namespace content 18 } // namespace content
19 19
20 namespace ppapi { 20 namespace ppapi {
21 21
22 // V8ObjectVar ----------------------------------------------------------------- 22 // V8ObjectVar -----------------------------------------------------------------
23 23
24 // Represents a JavaScript object Var. By itself, this represents random 24 // Represents a JavaScript object Var. By itself, this represents random
25 // v8 objects that a given plugin (identified by the resource's module) wants to 25 // v8 objects that a given plugin (identified by the resource's module) wants to
26 // reference. If two different modules reference the same NPObject (like the 26 // reference. If two different modules reference the same v8 object (like the
27 // "window" object), then there will be different V8ObjectVar's (and hence 27 // "window" object), then there will be different V8ObjectVar's (and hence
28 // PP_Var IDs) for each module. This allows us to track all references owned by 28 // PP_Var IDs) for each module. This allows us to track all references owned by
29 // a given module and free them when the plugin exits independently of other 29 // a given module and free them when the plugin exits independently of other
30 // plugins that may be running at the same time. 30 // plugins that may be running at the same time.
31 class CONTENT_EXPORT V8ObjectVar : public Var { 31 class CONTENT_EXPORT V8ObjectVar : public Var {
32 public: 32 public:
33 V8ObjectVar(PP_Instance instance, v8::Handle<v8::Object> v8_object); 33 V8ObjectVar(PP_Instance instance, v8::Handle<v8::Object> v8_object);
34 34
35 // Var overrides. 35 // Var overrides.
36 virtual V8ObjectVar* AsV8ObjectVar() OVERRIDE; 36 virtual V8ObjectVar* AsV8ObjectVar() OVERRIDE;
(...skipping 20 matching lines...) Expand all
57 content::PepperPluginInstanceImpl* instance_; 57 content::PepperPluginInstanceImpl* instance_;
58 58
59 v8::Persistent<v8::Object> v8_object_; 59 v8::Persistent<v8::Object> v8_object_;
60 60
61 DISALLOW_COPY_AND_ASSIGN(V8ObjectVar); 61 DISALLOW_COPY_AND_ASSIGN(V8ObjectVar);
62 }; 62 };
63 63
64 } // ppapi 64 } // ppapi
65 65
66 #endif // CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_ 66 #endif // CONTENT_RENDERER_PEPPER_V8OBJECT_VAR_H_
OLDNEW
« no previous file with comments | « content/renderer/pepper/npobject_var.cc ('k') | ppapi/shared_impl/var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698