Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 524193004: [SyncFS] Deflake SyncFileSystemServiceTest.SimpleLocalSyncFlow (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Deflake SyncFileSystemServiceTest.SimpleLocalSyncFlow Fix mock expectation for the flaky test. BUG=408443 TEST=unit_tests --gtest_filter=SyncFileSystemServiceTest.SimpleLocalSyncFlow Committed: https://crrev.com/af2ddaa039f67b19e193a8836aeec43bd45fd839 Cr-Commit-Position: refs/heads/master@{#292850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTL
6 years, 3 months ago (2014-09-01 07:17:46 UTC) #2
peria
lgtm
6 years, 3 months ago (2014-09-01 07:22:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/524193004/1
6 years, 3 months ago (2014-09-01 07:45:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 40a9371fcc6ef366b25e643b96b1f3eba057629f
6 years, 3 months ago (2014-09-01 08:37:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af2ddaa039f67b19e193a8836aeec43bd45fd839
Cr-Commit-Position: refs/heads/master@{#292850}

Powered by Google App Engine
This is Rietveld 408576698