Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 524193003: ServiceWorker: Temporarily disable layout tests (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Temporarily disable layout tests These tests will be broken by [2] and re-enabled by [3]. [1] Blink: THIS PATCH [2] Chromium: https://codereview.chromium.org/517493002/ [3] Blink: https://codereview.chromium.org/517223002/ BUG=406240 TEST=n/a NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181145

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : mark tests with 'Skip' instead of 'Failure Timeout' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nhiroki
Ptal, thanks!
6 years, 3 months ago (2014-09-01 03:20:51 UTC) #2
horo
https://codereview.chromium.org/524193003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/524193003/diff/20001/LayoutTests/TestExpectations#newcode1290 LayoutTests/TestExpectations:1290: crbug.com/405847 http/tests/serviceworker/install-phase-event-waituntil.html [ Pass Failure Timeout ] I think ...
6 years, 3 months ago (2014-09-01 03:41:51 UTC) #3
nhiroki
https://codereview.chromium.org/524193003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/524193003/diff/20001/LayoutTests/TestExpectations#newcode1290 LayoutTests/TestExpectations:1290: crbug.com/405847 http/tests/serviceworker/install-phase-event-waituntil.html [ Pass Failure Timeout ] On 2014/09/01 ...
6 years, 3 months ago (2014-09-01 03:50:19 UTC) #4
horo
lgtm
6 years, 3 months ago (2014-09-01 03:51:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/524193003/40001
6 years, 3 months ago (2014-09-01 04:03:23 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 04:03:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 181145

Powered by Google App Engine
This is Rietveld 408576698