Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/unittest/test/completion_test.dart

Issue 524153002: Sharing metatest logic between unittest and scheduled_test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: CR feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/test/completion_test.dart
diff --git a/pkg/unittest/test/completion_test.dart b/pkg/unittest/test/completion_test.dart
index c1ed574350071681a02f748a84671dcd4e7a29b5..b0c33d4fa02e70e3672404fe27ea736880c6c34e 100644
--- a/pkg/unittest/test/completion_test.dart
+++ b/pkg/unittest/test/completion_test.dart
@@ -2,28 +2,38 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library unittestTest;
-
-import 'dart:async';
-import 'dart:isolate';
+library unittest.completion_test;
+import 'package:metatest/metatest.dart';
import 'package:unittest/unittest.dart';
-part 'utils.dart';
+import 'utils.dart';
+
+void main() => initTests(_test);
-var testName = 'completion test';
+void _test(message) {
+ initMetatest(message);
-var testFunction = (TestConfiguration testConfig) {
- test(testName, () {
- var _callback;
- _callback = expectAsyncUntil(() {
- if (++testConfig.count < 10) {
- _defer(_callback);
- }
- },
- () => (testConfig.count == 10));
- _defer(_callback);
- });
-};
+ expectTestResults('completion test', () {
+ var count = 0;
+ test('test', () {
+ var _callback;
+ _callback = expectAsyncUntil(() {
+ if (++count < 10) {
+ defer(_callback);
+ }
+ }, () => (count == 10));
+ defer(_callback);
+ });
-var expected = buildStatusString(1, 0, 0, testName, count: 10);
+ test('verify count', () {
+ expect(count, 10);
+ });
+ }, [{
+ 'description': 'test',
+ 'result': 'pass'
+ }, {
+ 'description': 'verify count',
+ 'result': 'pass',
+ }]);
nweiz 2014/09/10 21:04:43 Why are you explicitly checking the test results f
kevmoo 2014/09/17 21:16:29 Done.
nweiz 2014/09/17 22:39:16 There are still a number of tests that do this.
kevmoo 2014/09/18 22:11:32 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698