Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: src/x64/ic-x64.cc

Issue 524059: Speed up compares with characters ie single-character strings.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | test/mjsunit/bit-not.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 // The key is not a smi. 323 // The key is not a smi.
324 // Is it a string? 324 // Is it a string?
325 __ CmpObjectType(rax, FIRST_NONSTRING_TYPE, rdx); 325 __ CmpObjectType(rax, FIRST_NONSTRING_TYPE, rdx);
326 __ j(above_equal, &slow); 326 __ j(above_equal, &slow);
327 // Is the string an array index, with cached numeric value? 327 // Is the string an array index, with cached numeric value?
328 __ movl(rbx, FieldOperand(rax, String::kHashFieldOffset)); 328 __ movl(rbx, FieldOperand(rax, String::kHashFieldOffset));
329 __ testl(rbx, Immediate(String::kIsArrayIndexMask)); 329 __ testl(rbx, Immediate(String::kIsArrayIndexMask));
330 330
331 // Is the string a symbol? 331 // Is the string a symbol?
332 __ j(not_zero, &index_string); // The value in rbx is used at jump target. 332 __ j(not_zero, &index_string); // The value in rbx is used at jump target.
333 ASSERT(kSymbolTag != 0);
333 __ testb(FieldOperand(rdx, Map::kInstanceTypeOffset), 334 __ testb(FieldOperand(rdx, Map::kInstanceTypeOffset),
334 Immediate(kIsSymbolMask)); 335 Immediate(kIsSymbolMask));
335 __ j(zero, &slow); 336 __ j(zero, &slow);
336 337
337 // If the receiver is a fast-case object, check the keyed lookup 338 // If the receiver is a fast-case object, check the keyed lookup
338 // cache. Otherwise probe the dictionary leaving result in rcx. 339 // cache. Otherwise probe the dictionary leaving result in rcx.
339 __ movq(rbx, FieldOperand(rcx, JSObject::kPropertiesOffset)); 340 __ movq(rbx, FieldOperand(rcx, JSObject::kPropertiesOffset));
340 __ Cmp(FieldOperand(rbx, HeapObject::kMapOffset), Factory::hash_table_map()); 341 __ Cmp(FieldOperand(rbx, HeapObject::kMapOffset), Factory::hash_table_map());
341 __ j(equal, &probe_dictionary); 342 __ j(equal, &probe_dictionary);
342 343
(...skipping 1040 matching lines...) Expand 10 before | Expand all | Expand 10 after
1383 1384
1384 // Cache miss: Jump to runtime. 1385 // Cache miss: Jump to runtime.
1385 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss))); 1386 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
1386 } 1387 }
1387 1388
1388 1389
1389 #undef __ 1390 #undef __
1390 1391
1391 1392
1392 } } // namespace v8::internal 1393 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | test/mjsunit/bit-not.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698