Chromium Code Reviews
Help | Chromium Project | Sign in
(43)

Issue 524059: Speed up compares with characters ie single-character strings.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by Erik Corry
Modified:
3 years, 11 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Speed up compares with characters ie single-character strings. Make use of it when we know that something can't be a NaN. Committed: http://code.google.com/p/v8/source/detail?r=3566

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+586 lines, -182 lines) Patch
M src/arm/codegen-arm.cc View 1 6 chunks +129 lines, -74 lines 0 comments Download
M src/codegen.h View 2 chunks +16 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 7 chunks +245 lines, -42 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 3 chunks +82 lines, -32 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/bit-not.js View 1 chunk +24 lines, -24 lines 0 comments Download
A test/mjsunit/compare-character.js View 1 1 chunk +50 lines, -0 lines 0 comments Download
M test/mjsunit/compare-nan.js View 1 1 chunk +22 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Erik Corry
5 years, 3 months ago (2010-01-07 14:19:00 UTC) #1
Kasper Lund
Comments: http://codereview.chromium.org/524059/diff/1/11 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/524059/diff/1/11#newcode4630 src/arm/codegen-arm.cc:4630: // special: (undefined == undefined) == true, but ...
5 years, 3 months ago (2010-01-08 07:25:37 UTC) #2
Kasper Lund
5 years, 3 months ago (2010-01-08 09:31:34 UTC) #3
One more thing:

http://codereview.chromium.org/524059/diff/1/7
File src/codegen.h (right):

http://codereview.chromium.org/524059/diff/1/7#newcode320
src/codegen.h:320: enum NaNInformation { BothCouldBeNaN, CantBothBeNaN };
Split on multiple lines. Fix naming. Should be either BOTH_COULD_BE_NAN or
kBothCouldBeNaN.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771