Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 52403002: Reland "Enable SysInfo::AmountOfPhysicalMemory to be called from within the Linux Sandbox" (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland "Enable SysInfo::AmountOfPhysicalMemory to be called from within the Linux Sandbox" Trigger caching of SysInfo::AmountOfPhysicalMemory in PreSandboxInit() to enable it to be called by the renderer process after the sandbox is sealed. BUG=312241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232274

Patch Set 1 #

Patch Set 2 : Avoid doing IO in LazySysInfo initializer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M base/sys_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/sys_info_linux.cc View 1 2 chunks +47 lines, -23 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rmcilroy
This relands https://codereview.chromium.org/28833002/, which was reverted due to doing IO on a non-IO thread in ...
7 years, 1 month ago (2013-10-30 12:13:03 UTC) #1
jar (doing other things)
lgtm
7 years, 1 month ago (2013-10-31 17:32:11 UTC) #2
jln (very slow on Chromium)
On 2013/10/31 17:32:11, jar wrote: > lgtm Zygote lgtm
7 years, 1 month ago (2013-10-31 17:46:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/52403002/20001
7 years, 1 month ago (2013-10-31 18:01:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=216764
7 years, 1 month ago (2013-10-31 21:20:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/52403002/20001
7 years, 1 month ago (2013-10-31 23:42:02 UTC) #6
commit-bot: I haz the power
Change committed as 232274
7 years, 1 month ago (2013-11-01 01:55:44 UTC) #7
dglazkov
This broke all Linux dbg layout tests again. Please don't land again until you're sure ...
7 years, 1 month ago (2013-11-01 03:04:27 UTC) #8
rmcilroy
7 years, 1 month ago (2013-11-01 09:34:34 UTC) #9
On 2013/11/01 03:04:27, Dimitri Glazkov wrote:
> This broke all Linux dbg layout tests again. Please don't land again until
> you're sure this won't happen again.

Apologies Dimitri, I thought I had removed all IO references and tested locally,
but obviously missed one and didn't test the correct configuration locally. I
will make sure it passes on the linux_layout trybot before relanding (I didn't
realise you could run chromium changes through this trybot).

Powered by Google App Engine
This is Rietveld 408576698