Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Issue 524023002: Revert of Disable UI flags for non-desktop OSes (Closed)

Created:
6 years, 3 months ago by Mike Lerman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, acleung1
Project:
chromium
Visibility:
Public.

Description

Revert of Disable UI flags for non-desktop OSes (patchset #4 id:60001 of https://codereview.chromium.org/480453002/) Reason for revert: This will cause android to lose account consistency. I should not have removed the file! Original issue's description: > Disable UI flags for non-desktop OSes > > This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes. > > BUG=404066 > > Committed: https://chromium.googlesource.com/chromium/src/+/8003a95bb88e1d25ad59251b5d7e8609d76e5669 TBR=noms@chromium.org,rogerta@chromium.org,newt@chromium.org,dzhioev@chromium.org,aruslan@chromium.org,xiyuan@chromium.org,nkostylev@chromium.org NOTREECHECKS=true NOTRY=true BUG=404066 Committed: https://crrev.com/7371f2ce2c82288fe06121fb186cd7a9aa023be0 Cr-Commit-Position: refs/heads/master@{#292789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mike Lerman
Created Revert of Disable UI flags for non-desktop OSes
6 years, 3 months ago (2014-08-30 01:10:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/524023002/1
6 years, 3 months ago (2014-08-30 01:11:56 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-30 01:11:58 UTC) #4
noms (inactive)
lgtm
6 years, 3 months ago (2014-08-30 13:50:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/524023002/1
6 years, 3 months ago (2014-08-30 14:03:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as f32da36339e8512e7cce9acab8f70caf5375bf21
6 years, 3 months ago (2014-08-30 14:04:39 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7371f2ce2c82288fe06121fb186cd7a9aa023be0
Cr-Commit-Position: refs/heads/master@{#292789}

Powered by Google App Engine
This is Rietveld 408576698