Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: chrome/browser/cocoa/extensions/browser_actions_controller.mm

Issue 524023: [Mac] Fixes bug where clicking a Browser Action button twice quickly will res... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/extensions/browser_actions_controller.mm
===================================================================
--- chrome/browser/cocoa/extensions/browser_actions_controller.mm (revision 35472)
+++ chrome/browser/cocoa/extensions/browser_actions_controller.mm (working copy)
@@ -443,6 +443,10 @@
// Adjust the anchor point to be at the center of the browser action button.
arrowPoint.x += kBrowserActionWidth / 2;
+ // Close any existing (or loading) popup owned by this controller.
+ if (popupController_)
+ [self hidePopup];
+
popupController_ = [ExtensionPopupController showURL:action->popup_url()
inBrowser:browser_
anchoredAt:arrowPoint
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698