Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 524023: [Mac] Fixes bug where clicking a Browser Action button twice quickly will res... (Closed)

Created:
10 years, 11 months ago by Bons
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

[Mac] Fixes bug where clicking a Browser Action button twice quickly will result in a sticky popup from the original click. BUG=31097 TEST=Click on a browser action button (with a popup) twice very quickly. A popup should show up, but once you click outside of it, it should not remain. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/cocoa/extensions/browser_actions_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bons
10 years, 11 months ago (2010-01-04 23:26:02 UTC) #1
Pam (message me for reviews)
LGTM. Why did this only apply if you clicked twice quickly? - Pam
10 years, 11 months ago (2010-01-04 23:34:18 UTC) #2
andybons
10 years, 11 months ago (2010-01-04 23:39:16 UTC) #3
The expectation was that popupController_ would always be nil if a
popup is not currently being displayed (it is nil'd out once the popup
is closed and nil initially). The problem with that assumption is that
there is a short delay from the time you click the button to when it
displays (it waits for a load notification). This presents a problem
because then you have an errant popup controller object that is never
destroyed but simply replaced by whichever one loads last.

On Mon, Jan 4, 2010 at 6:34 PM,  <pam@chromium.org> wrote:
> LGTM.
>
> Why did this only apply if you clicked twice quickly?
>
> - Pam
>
> http://codereview.chromium.org/524023
>

Powered by Google App Engine
This is Rietveld 408576698