Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 523813003: Revert of Landing Recent QUIC Changes. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc, Jana, Ian Swett, rjshade, alyssar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Landing Recent QUIC Changes. (patchset #1 id:1 of https://codereview.chromium.org/515303003/) Reason for revert: Reverting to see if it fixes the following issue. Crash rate has gone up by 10 times. BUG=409191 Original issue's description: > Landing Recent QUIC Changes. > > Nest a QUIC SerializedPacket inside a QUIC QueuedPacket. > > Merge internal change: 74239145 > https://codereview.chromium.org/509203003/ > > > Remove PacketType from QUIC because the QUEUED type is not used and the > other types can be reduced to a bool. > > Merge internal change: 74148481 > https://codereview.chromium.org/515003003/ > > > Don't send a QUIC SCUP message until after handshake confirmed. > > A server config update was occasionally being sent before the crypto > handshake was complete, causing the client to close the connection. > > Merge internal change: 74132773 > https://codereview.chromium.org/516713002/ > > > Change TransmissionInfo's all_transmissions SequenceNumberSet* to > default to NULL, and only be present if there are multiple transmissions. > > Estimated to save ~2% of CPU. > > Merge internal change: 74076012 > https://codereview.chromium.org/509073004/ > > > Log the quic version for internal server tracing. > Not used in production. > > Merge internal change: 74069715 > https://codereview.chromium.org/514043002/ > > > Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a > deque. > > Estimated to save ~3% of CPU based on pprof profiling of 100 large gets > on tools/quic/end_to_end_test.cc. > > Merge internal change: 74054196 > https://codereview.chromium.org/514033002/ > > > Unit test for empty packet closes QUIC connection bug. > > Merge internal change: 74041239 > https://codereview.chromium.org/495423011/ > > > Log the QUIC transmission type in QUIC internal server trace visitor. > Not used in production. > > Merge internal change: 73895739 > https://codereview.chromium.org/514023002/ > > > Not used in production. Log whether a QUIC packet sent was a crypto > packet or not for internal server side tracing. > > Merge internal change: 73894063 > https://codereview.chromium.org/515003002/ > > > Fix a QUIC bug in which PING frames were not being ACK'd. > > Merge internal change: 73837644 > https://codereview.chromium.org/512933005/ > > R=rch@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949 TBR=rch@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/00f180a54e0ebf53bcadebc9983ee406818f232b Cr-Commit-Position: refs/heads/master@{#292722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -444 lines) Patch
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M net/quic/quic_connection.h View 5 chunks +12 lines, -8 lines 0 comments Download
M net/quic/quic_connection.cc View 20 chunks +69 lines, -86 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 5 chunks +144 lines, -44 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 5 chunks +8 lines, -9 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 15 chunks +89 lines, -69 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 6 chunks +6 lines, -13 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 9 chunks +148 lines, -131 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 3 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Created Revert of Landing Recent QUIC Changes.
6 years, 3 months ago (2014-08-29 23:36:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/523813003/1
6 years, 3 months ago (2014-08-29 23:39:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3a0973acdbfa8a0645914a8c16a3693924fecc8d
6 years, 3 months ago (2014-08-29 23:54:18 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00f180a54e0ebf53bcadebc9983ee406818f232b
Cr-Commit-Position: refs/heads/master@{#292722}

Powered by Google App Engine
This is Rietveld 408576698