Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 523733003: Revert of Disable BrowserTest.InterstitialCloseTab which is flaky. (Closed)

Created:
6 years, 3 months ago by ccameron
Modified:
6 years, 3 months ago
Reviewers:
jam, mattm
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Disable BrowserTest.InterstitialCloseTab which is flaky. (patchset #1 id:1 of https://codereview.chromium.org/424143003/) Reason for revert: This should be fixed by r288895 Original issue's description: > Disable BrowserTest.InterstitialCloseTab which is flaky. > > BUG=393218 > TBR=mattm@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286225 TBR=mattm@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=393218 Committed: https://crrev.com/14cb9047f56c1e397306a83fda9a26b43d2125bf Cr-Commit-Position: refs/heads/master@{#292707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
Created Revert of Disable BrowserTest.InterstitialCloseTab which is flaky.
6 years, 3 months ago (2014-08-29 21:06:11 UTC) #1
mattm
lgtm
6 years, 3 months ago (2014-08-29 21:08:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/523733003/1
6 years, 3 months ago (2014-08-29 21:59:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7fca7b7c5ddd82bbb49fa923b00e2ee66ac5a024
6 years, 3 months ago (2014-08-29 23:07:27 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14cb9047f56c1e397306a83fda9a26b43d2125bf
Cr-Commit-Position: refs/heads/master@{#292707}

Powered by Google App Engine
This is Rietveld 408576698