Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 523663002: Video Player: Show the appropriate error message on casting unsupported video (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Show the appropriate error message on casting unsupported video Previously, the error message was 'An error occurred.' This patch changes it to "This file could not be displayed." BUG=405860 TEST=manually tested TBR=fukino@chromium.org Committed: https://crrev.com/d6768ca8c6658005b3485f4c7a7a167ec49f88fd Cr-Commit-Position: refs/heads/master@{#292832}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 5 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoshiki
yoshiki@chromium.org changed reviewers: + fukino@chromium.org
6 years, 3 months ago (2014-08-29 15:30:31 UTC) #1
yoshiki
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-29 15:30:40 UTC) #2
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 3 months ago (2014-08-29 15:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/523663002/20001
6 years, 3 months ago (2014-08-29 15:33:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-29 16:27:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 16:38:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/10470)
6 years, 3 months ago (2014-08-29 16:38:12 UTC) #7
yoshiki
Committed patchset #1 (id:20001) manually as d6768ca (presubmit successful).
6 years, 3 months ago (2014-09-01 04:23:02 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6768ca8c6658005b3485f4c7a7a167ec49f88fd
Cr-Commit-Position: refs/heads/master@{#292832}

Powered by Google App Engine
This is Rietveld 408576698