Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 523633002: Fix typed lowering of JSUnaryNot to work with graph reducer. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix typed lowering of JSUnaryNot to work with graph reducer. R=titzer@chromium.org TEST=cctest/test-js-typed-lowering/UnaryNot[Effects] Committed: https://code.google.com/p/v8/source/detail?r=23561

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments by Ben Titzer. #

Patch Set 3 : Rebased and comments fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 2 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-08-29 14:32:04 UTC) #1
titzer
https://codereview.chromium.org/523633002/diff/1/test/cctest/compiler/test-js-typed-lowering.cc File test/cctest/compiler/test-js-typed-lowering.cc (right): https://codereview.chromium.org/523633002/diff/1/test/cctest/compiler/test-js-typed-lowering.cc#newcode761 test/cctest/compiler/test-js-typed-lowering.cc:761: IrOpcode::kJSToBoolean == r->opcode()); Can you use a value use ...
6 years, 3 months ago (2014-08-29 15:49:39 UTC) #2
Michael Starzinger
https://codereview.chromium.org/523633002/diff/1/test/cctest/compiler/test-js-typed-lowering.cc File test/cctest/compiler/test-js-typed-lowering.cc (right): https://codereview.chromium.org/523633002/diff/1/test/cctest/compiler/test-js-typed-lowering.cc#newcode761 test/cctest/compiler/test-js-typed-lowering.cc:761: IrOpcode::kJSToBoolean == r->opcode()); On 2014/08/29 15:49:38, titzer wrote: > ...
6 years, 3 months ago (2014-09-01 10:25:40 UTC) #3
titzer
lgtm
6 years, 3 months ago (2014-09-01 11:42:13 UTC) #4
Michael Starzinger
6 years, 3 months ago (2014-09-01 12:17:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 23561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698