Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 523603002: Revert of Skia roll 60cc7d3:088f4b8 (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, djsollen, vabr (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Skia roll 60cc7d3:088f4b8 (patchset #1 of https://codereview.chromium.org/516973003/) Reason for revert: Make WebKit Linux (dbg) to crash while running: virtual/gpu/fast/canvas/canvas-style-intact-after-text.html Original issue's description: > Skia roll 60cc7d3:088f4b8 > > https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059 > > CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=djsollen@google.com > > Committed: https://chromium.googlesource.com/chromium/src/+/06f45538f0dbff916938fc4a949875991c02c06a TBR=djsollen@google.com,skia-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5ea692e8b2019af721b9ddf33ef1c945239c8fdc Cr-Commit-Position: refs/heads/master@{#292619}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Skia roll 60cc7d3:088f4b8
6 years, 3 months ago (2014-08-29 13:18:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/523603002/1
6 years, 3 months ago (2014-08-29 13:19:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 13:19:49 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-08-29 13:19:50 UTC) #4
mlamouri (slow - plz ping)
I'm going to manually modify the DEPS file.
6 years, 3 months ago (2014-08-29 13:24:49 UTC) #5
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 3 months ago (2014-08-29 13:27:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/523603002/40001
6 years, 3 months ago (2014-08-29 13:28:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 8e178f58788cca1dee5d4caad2935db0e423d60f
6 years, 3 months ago (2014-08-29 13:29:10 UTC) #8
mtklein
On 2014/08/29 13:29:10, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:40001) as ...
6 years, 3 months ago (2014-08-29 13:58:45 UTC) #9
mlamouri (slow - plz ping)
On 2014/08/29 13:58:45, mtklein wrote: > (I'm also looking into having us run debug layout ...
6 years, 3 months ago (2014-08-29 14:11:31 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ea692e8b2019af721b9ddf33ef1c945239c8fdc
Cr-Commit-Position: refs/heads/master@{#292619}

Powered by Google App Engine
This is Rietveld 408576698