Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 523593002: Improve graph visualizer for deoptimization and readablity. (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Improve graph visualizer for deoptimization and readablity. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23582

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adressing comments + rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M src/compiler/graph-visualizer.cc View 1 6 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sigurds
PTAL
6 years, 3 months ago (2014-08-29 12:44:21 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/523593002/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/523593002/diff/1/src/compiler/graph-visualizer.cc#newcode213 src/compiler/graph-visualizer.cc:213: << (NodeProperties::IsControlEdge(edge) ? "style=dashed" : "") suggestion: As ...
6 years, 3 months ago (2014-09-01 10:47:11 UTC) #2
sigurds
FYI https://codereview.chromium.org/523593002/diff/1/src/compiler/graph-visualizer.cc File src/compiler/graph-visualizer.cc (right): https://codereview.chromium.org/523593002/diff/1/src/compiler/graph-visualizer.cc#newcode213 src/compiler/graph-visualizer.cc:213: << (NodeProperties::IsControlEdge(edge) ? "style=dashed" : "") On 2014/09/01 ...
6 years, 3 months ago (2014-09-02 08:43:53 UTC) #3
sigurds
6 years, 3 months ago (2014-09-02 08:44:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698