Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 523583002: Multiple stubs can point to the same calling convention. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Multiple stubs can point to the same calling convention. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23546

Patch Set 1 #

Patch Set 2 : A bit of cleanup. #

Patch Set 3 : Changed is-a to has-a with CodeStubInterfaceDescriptor. #

Patch Set 4 : x64 port. #

Patch Set 5 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1109 lines, -933 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 4 chunks +27 lines, -196 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 4 1 chunk +150 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 chunks +27 lines, -235 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 4 1 chunk +189 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 5 chunks +45 lines, -11 lines 0 comments Download
M src/code-stubs.cc View 1 2 6 chunks +191 lines, -64 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 4 chunks +12 lines, -18 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 6 chunks +22 lines, -182 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 2 chunks +150 lines, -0 lines 0 comments Download
M src/ic/arm/ic-conventions-arm.cc View 1 2 3 4 1 chunk +5 lines, -9 lines 0 comments Download
M src/ic/arm64/ic-conventions-arm64.cc View 1 2 3 4 2 chunks +15 lines, -8 lines 0 comments Download
M src/ic/ia32/ic-conventions-ia32.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M src/ic/ic-conventions.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/x64/ic-conventions-x64.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M src/interface-descriptors.h View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 5 chunks +27 lines, -191 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 3 1 chunk +150 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Patchset #3 (id:40001) has been deleted
6 years, 3 months ago (2014-08-29 13:00:57 UTC) #1
mvstanton
mvstanton@chromium.org changed reviewers: + yangguo@chromium.org
6 years, 3 months ago (2014-08-29 13:05:39 UTC) #2
mvstanton
Hi Yang, Here is step 2: the call interface descriptor is now something that a ...
6 years, 3 months ago (2014-08-29 13:05:39 UTC) #3
Yang
On 2014/08/29 13:05:39, mvstanton wrote: > Hi Yang, > Here is step 2: the call ...
6 years, 3 months ago (2014-09-01 07:08:12 UTC) #4
mvstanton
6 years, 3 months ago (2014-09-01 09:18:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:100001) manually as 23546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698