Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
523573002:
Remove unused tools/safely-roll-blink.py (Closed)
|
Created:
6 years, 3 months ago by mlamouri (slow - plz ping) Modified:
6 years, 3 months ago Reviewers:
borenet2 CC:
chromium-reviews, eseidel, Dirk Pranke Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionRemove unused tools/safely-roll-blink.py
It will require an update of the gardening documentation to point to
safely-roll-deps.py instead of safely-roll-blink.py:
http://www.chromium.org/blink/gardening
BUG=None
TBR=eseidel@chromium.org (current LGTM not accepted...)
Committed: https://crrev.com/5b9d8148df5514004023efd9084cf90f3d2ac6c5
Cr-Commit-Position: refs/heads/master@{#292633}
Patch Set 1 #
Messages
Total messages: 21 (0 generated)
mlamouri@chromium.org changed reviewers: + borenet@chromium.org
Based on the following discussions, this script is no longer needed: https://codereview.chromium.org/510343002/ http://code.google.com/p/chromium/issues/detail?id=406867 The gardening documentation seems to be the only place where it is referenced. I will update it after deletion.
LGTM
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/523573002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/523573002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/523573002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/523573002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 9027300e33c698656985cb007aa575e3e2db5aa2
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5b9d8148df5514004023efd9084cf90f3d2ac6c5 Cr-Commit-Position: refs/heads/master@{#292633} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
