Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 52353003: IDL compiler: 3 more special types for methods (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: 3 more special types for methods 3 last special types: * CompareHow * Dictionary * MediaQueryListListener Only Dictionary involves a new block of code; others are just type handling. Also a bit of cleaning up of type code and test categories. BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160994

Patch Set 1 #

Total comments: 6

Patch Set 2 : Revised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -65 lines) Patch
M Source/bindings/scripts/unstable/v8_types.py View 1 5 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 4 chunks +15 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 15 chunks +186 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
https://codereview.chromium.org/52353003/diff/1/Source/bindings/scripts/unstable/v8_types.py File Source/bindings/scripts/unstable/v8_types.py (right): https://codereview.chromium.org/52353003/diff/1/Source/bindings/scripts/unstable/v8_types.py#newcode241 Source/bindings/scripts/unstable/v8_types.py:241: # FIXME: can these be merged to NON_WRAPPER_TYPES? Same ...
7 years, 1 month ago (2013-10-30 11:21:14 UTC) #1
haraken
LGTM https://codereview.chromium.org/52353003/diff/1/Source/bindings/scripts/unstable/v8_types.py File Source/bindings/scripts/unstable/v8_types.py (right): https://codereview.chromium.org/52353003/diff/1/Source/bindings/scripts/unstable/v8_types.py#newcode241 Source/bindings/scripts/unstable/v8_types.py:241: # FIXME: can these be merged to NON_WRAPPER_TYPES? ...
7 years, 1 month ago (2013-10-30 11:32:15 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/52353003/diff/1/Source/bindings/scripts/unstable/v8_types.py File Source/bindings/scripts/unstable/v8_types.py (right): https://codereview.chromium.org/52353003/diff/1/Source/bindings/scripts/unstable/v8_types.py#newcode241 Source/bindings/scripts/unstable/v8_types.py:241: # FIXME: can these be merged to NON_WRAPPER_TYPES? On ...
7 years, 1 month ago (2013-10-31 01:10:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/52353003/90001
7 years, 1 month ago (2013-10-31 01:10:21 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 01:10:36 UTC) #5
Message was sent while issue was closed.
Change committed as 160994

Powered by Google App Engine
This is Rietveld 408576698