Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 523523002: Cleanup: Move check_grd_for_unused_strings.py out of chrome/ (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Nico, TVL
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move check_grd_for_unused_strings.py out of chrome/ It isn't specific to chrome, it has a broader usage. BUG=None TEST=./tools/check_grd_for_unused_strings.py R=thestig@chromium.org Committed: https://crrev.com/c9fc190dc2c26f6bea35ff8cf33e209d04e7b41c Cr-Commit-Position: refs/heads/master@{#292646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -187 lines) Patch
D chrome/tools/check_grd_for_unused_strings.py View 1 chunk +0 lines, -183 lines 0 comments Download
A + tools/check_grd_for_unused_strings.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 3 months ago (2014-08-29 03:37:35 UTC) #1
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-29 04:28:19 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-29 15:22:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/523523002/1
6 years, 3 months ago (2014-08-29 15:22:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 16a9e9bbcd318bf476605d0b2a4097aab303be62
6 years, 3 months ago (2014-08-29 16:19:09 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9fc190dc2c26f6bea35ff8cf33e209d04e7b41c
Cr-Commit-Position: refs/heads/master@{#292646}

Powered by Google App Engine
This is Rietveld 408576698