Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 523463007: Fix bug in QuicHttpStream::SendRequest. (Closed)

Created:
6 years, 3 months ago by Ryan Hamilton
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bug in QuicHttpStream::SendRequest. If the session is closed before SendRequest is called, a CHECK would fire in SendRequest(). BUG=409101 Committed: https://crrev.com/f9f103cbc943019e6576a68c724a6360da26b687 Cr-Commit-Position: refs/heads/master@{#292775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M net/quic/quic_http_stream.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Hamilton
6 years, 3 months ago (2014-08-29 21:43:33 UTC) #2
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-08-29 22:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/523463007/1
6 years, 3 months ago (2014-08-30 03:43:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a9fc109a109b1c420dca1d054ee63427a07a6166
6 years, 3 months ago (2014-08-30 05:29:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9f103cbc943019e6576a68c724a6360da26b687
Cr-Commit-Position: refs/heads/master@{#292775}

Powered by Google App Engine
This is Rietveld 408576698