Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 523463003: Manual fixups in chrome/ for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manual fixups in chrome/ for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/ba3229b241c25b90c55fb4e88348d008cd179ff6 Cr-Commit-Position: refs/heads/master@{#292564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/power/process_power_collector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-29 00:07:52 UTC) #1
dcheng
Fairly straightforward set of manual fixups--I believe it's safe to call .get() in all of ...
6 years, 3 months ago (2014-08-29 00:07:52 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-08-29 02:16:12 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-29 02:31:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/523463003/1
6 years, 3 months ago (2014-08-29 02:32:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d8ec621f2b9115c6edf212bb291f3ee5f9d3a63d
6 years, 3 months ago (2014-08-29 03:24:16 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:06:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba3229b241c25b90c55fb4e88348d008cd179ff6
Cr-Commit-Position: refs/heads/master@{#292564}

Powered by Google App Engine
This is Rietveld 408576698