Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 523433002: Fix the Copresence permission. (Closed)

Created:
6 years, 3 months ago by rkc
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the Copresence permission. The initializer for the Copresence permission is malformed. It specifies the message id instead of the flag. R=kalman@chromium.org BUG=408843 Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8 Committed: https://crrev.com/5df416cab1a378864933a89cd9f7f81b91788633 Cr-Commit-Position: refs/heads/master@{#292952}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (1 generated)
rkc
6 years, 3 months ago (2014-08-28 23:24:49 UTC) #1
not at google - send to devlin
lgtm
6 years, 3 months ago (2014-08-28 23:25:20 UTC) #2
rkc
Committed patchset #1 (id:1) to pending queue manually as c2a41e8 (presubmit successful).
6 years, 3 months ago (2014-08-28 23:33:28 UTC) #3
Alpha Left Google
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/520493002/ by hclam@chromium.org. The ...
6 years, 3 months ago (2014-08-29 01:10:23 UTC) #4
not at google - send to devlin
Rkc please dont dcommit especially without running a try run.
6 years, 3 months ago (2014-08-29 01:13:05 UTC) #5
benwells
On 2014/08/29 01:13:05, kalman wrote: > Rkc please dont dcommit especially without running a try ...
6 years, 3 months ago (2014-08-29 02:49:43 UTC) #6
rkc
I apologize. I usually don't land without the CQ but this 'seemed' like a harmless ...
6 years, 3 months ago (2014-09-02 15:28:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/523433002/20001
6 years, 3 months ago (2014-09-02 15:59:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-09-02 17:01:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b780a3047c20759afb14159fa4ac0ffe0d5f4cf6
6 years, 3 months ago (2014-09-02 17:32:12 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/99ae5386b85f81eb7ae3d811c240535b721017b8 Cr-Commit-Position: refs/heads/master@{#292495}
6 years, 3 months ago (2014-09-10 03:03:24 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5df416cab1a378864933a89cd9f7f81b91788633
Cr-Commit-Position: refs/heads/master@{#292952}

Powered by Google App Engine
This is Rietveld 408576698