Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: media/filters/renderer_impl.h

Issue 523283002: media: Introduce DemuxerStreamProvider interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/renderer_impl.h
diff --git a/media/filters/renderer_impl.h b/media/filters/renderer_impl.h
index aa7918a2cb251208cd57035b77bdc98e9d76bbdc..02c730190de2d0e89c21112e902aef1aea95cfaa 100644
--- a/media/filters/renderer_impl.h
+++ b/media/filters/renderer_impl.h
@@ -24,20 +24,23 @@ class SingleThreadTaskRunner;
namespace media {
class AudioRenderer;
-class Demuxer;
+class DemuxerStreamProvider;
class TimeDeltaInterpolator;
class TimeSource;
class VideoRenderer;
class MEDIA_EXPORT RendererImpl : public Renderer {
public:
- // Renders audio/video streams in |demuxer| using |audio_renderer| and
- // |video_renderer| provided. All methods except for GetMediaTime() run on the
- // |task_runner|. GetMediaTime() runs on the render main thread because it's
- // part of JS sync API. |get_duration_cb| is used to get the duration of the
- // stream.
+ // Renders audio/video streams in |demuxer_stream_provider| using
+ // |audio_renderer| and |video_renderer| provided.
+ // Notes:
+ // - |demuxer_stream_provider| and the streams it provides are guaranteed to
+ // be valid during the lifetime of this object.
+ // - All methods except for GetMediaTime() run on the |task_runner|.
+ // GetMediaTime() runs on the render main thread because it's part of JS
+ // sync API. |get_duration_cb| is used to get the duration of the stream.
RendererImpl(const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
- Demuxer* demuxer,
+ DemuxerStreamProvider* demuxer_stream_provider,
scoped_ptr<AudioRenderer> audio_renderer,
scoped_ptr<VideoRenderer> video_renderer);
@@ -128,7 +131,7 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
// Task runner used to execute pipeline tasks.
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
- Demuxer* demuxer_;
+ DemuxerStreamProvider* demuxer_stream_provider_;
// Permanent callback to get the media duration.
TimeDeltaCB get_duration_cb_;

Powered by Google App Engine
This is Rietveld 408576698