Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: cc/resources/raster_worker_pool_unittest.cc

Issue 523243002: cc: Generalize raster task notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unused ctor Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/raster_worker_pool_unittest.cc
diff --git a/cc/resources/raster_worker_pool_unittest.cc b/cc/resources/raster_worker_pool_unittest.cc
index 172d0873cbff9815f8a965551d2b6faa3396b1be..870a634a492043a60488b77223207e95b923c2e7 100644
--- a/cc/resources/raster_worker_pool_unittest.cc
+++ b/cc/resources/raster_worker_pool_unittest.cc
@@ -109,6 +109,12 @@ class RasterWorkerPoolTest
typedef std::vector<scoped_refptr<RasterTask> > RasterTaskVector;
+ enum NamedTaskSet {
+ HIGH_RESOLUTION_IN_NOW_BIN_ON_ACTIVE_TREE = 0,
+ REQUIRED_FOR_ACTIVATION = 1,
+ ALL = 2
+ };
+
RasterWorkerPoolTest()
: context_provider_(TestContextProvider::Create()),
timeout_seconds_(5),
@@ -173,15 +179,15 @@ class RasterWorkerPoolTest
}
// Overriden from RasterWorkerPoolClient:
- virtual bool ShouldForceTasksRequiredForActivationToComplete() const
- OVERRIDE {
- return false;
+ virtual void DidFinishRunningTasks(TaskSet task_set) OVERRIDE {
+ if (task_set == ALL) {
+ raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks();
reveman 2014/09/16 22:49:05 remove the conditional for this if possible.
ernstm 2014/09/17 19:57:15 Done.
+ base::MessageLoop::current()->Quit();
reveman 2014/09/16 22:49:05 We should switch this test over to using TestSimpl
ernstm 2014/09/17 19:57:15 Done.
+ }
}
- virtual void DidFinishRunningTasks() OVERRIDE {
- raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks();
- base::MessageLoop::current()->Quit();
+ virtual TaskSetCollection TasksThatShouldBeForcedToComplete() const OVERRIDE {
+ return TaskSetCollection();
}
- virtual void DidFinishRunningTasksRequiredForActivation() OVERRIDE {}
void RunMessageLoopUntilAllTasksHaveCompleted() {
if (timeout_seconds_) {
@@ -205,8 +211,12 @@ class RasterWorkerPoolTest
for (RasterTaskVector::const_iterator it = tasks_.begin();
it != tasks_.end();
- ++it)
- queue.items.push_back(RasterTaskQueue::Item(it->get(), false));
+ ++it) {
+ TaskSetCollection task_set_collection;
reveman 2014/09/16 22:49:05 nit: s/task_set_collection/task_sets/
ernstm 2014/09/17 19:57:15 Done.
+ task_set_collection[ALL] = true;
+ queue.items.push_back(
+ RasterTaskQueue::Item(it->get(), task_set_collection));
+ }
raster_worker_pool_->AsRasterizer()->ScheduleTasks(&queue);
}

Powered by Google App Engine
This is Rietveld 408576698