Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: cc/resources/raster_worker_pool_perftest.cc

Issue 523243002: cc: Generalize raster task notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renaming Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/raster_worker_pool_perftest.cc
diff --git a/cc/resources/raster_worker_pool_perftest.cc b/cc/resources/raster_worker_pool_perftest.cc
index 436615caac950a9702326d0689bc3383a8dfc58c..70e002fd3a17ef3793a50339640a36ba94ab1081 100644
--- a/cc/resources/raster_worker_pool_perftest.cc
+++ b/cc/resources/raster_worker_pool_perftest.cc
@@ -147,6 +147,12 @@ class RasterWorkerPoolPerfTestBase {
public:
typedef std::vector<scoped_refptr<RasterTask> > RasterTaskVector;
+ enum NamedTaskSet {
+ HIGH_RESOLUTION_IN_NOW_BIN_ON_ACTIVE_TREE = 0,
+ REQUIRED_FOR_ACTIVATION = 1,
+ ALL = 2
+ };
+
RasterWorkerPoolPerfTestBase()
: context_provider_(make_scoped_refptr(new PerfContextProvider)),
task_runner_(new base::TestSimpleTaskRunner),
@@ -196,9 +202,11 @@ class RasterWorkerPoolPerfTestBase {
const RasterTaskVector& raster_tasks) {
for (size_t i = 0u; i < raster_tasks.size(); ++i) {
bool required_for_activation = (i % 2) == 0;
- queue->items.push_back(RasterTaskQueue::Item(raster_tasks[i].get(),
- required_for_activation));
- queue->required_for_activation_count += required_for_activation;
+ TaskSetCollection task_set_collection;
+ task_set_collection[ALL] = true;
+ task_set_collection[REQUIRED_FOR_ACTIVATION] = required_for_activation;
+ queue->items.push_back(
+ RasterTaskQueue::Item(raster_tasks[i].get(), task_set_collection));
}
}
@@ -262,14 +270,17 @@ class RasterWorkerPoolPerfTest
}
// Overriden from RasterizerClient:
- virtual bool ShouldForceTasksRequiredForActivationToComplete() const
- OVERRIDE {
- return false;
+ virtual void DidFinishRunningTasks(TaskSet task_set) OVERRIDE {
+ if (task_set == ALL)
+ raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks();
}
- virtual void DidFinishRunningTasks() OVERRIDE {
- raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks();
+ virtual TaskSetCollection TasksThatShouldBeForcedToComplete() const OVERRIDE {
+ return TaskSetCollection();
+ }
+ virtual base::debug::TraceEventSyntheticDelay* SyntheticDelayForTasks(
+ TaskSet task_set) const OVERRIDE {
+ return NULL;
}
- virtual void DidFinishRunningTasksRequiredForActivation() OVERRIDE {}
void RunMessageLoopUntilAllTasksHaveCompleted() {
task_graph_runner_->RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698