Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3634)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 523233002: mac: Remove simplified fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_fullscreen2
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h
index 9e7a9a67ddaee752e8a9199f4b0a3c6e21a10939..6567ae48e37cf9de94ea9422490a3f65e9ed0533 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller.h
@@ -60,7 +60,6 @@ class Command;
namespace fullscreen_mac {
enum SlidingStyle {
OMNIBOX_TABS_PRESENT = 0, // Tab strip and omnibox both visible.
- OMNIBOX_PRESENT, // Tab strip hidden.
OMNIBOX_TABS_HIDDEN, // Tab strip and omnibox both hidden.
};
} // namespace fullscreen_mac
@@ -429,12 +428,10 @@ enum SlidingStyle {
// invoked causes all fullscreen modes to exit.
//
// ----------------------------------------------------------------------------
-// There are 3 "styles" of omnibox sliding.
+// There are 2 "styles" of omnibox sliding.
// + OMNIBOX_TABS_PRESENT: Both the omnibox and the tabstrip are present.
// Moving the cursor to the top causes the menubar to appear, and everything
// else to slide down.
-// + OMNIBOX_PRESENT: The tabstrip is hidden. Moving the cursor to the top
-// shows the tabstrip and menubar, sliding everything else down.
// + OMNIBOX_TABS_HIDDEN: Both tabstrip and omnibox are hidden. Moving cursor
// to top shows tabstrip, omnibox, and menu bar.
//
@@ -468,11 +465,6 @@ enum SlidingStyle {
//
// + HTML5 fullscreen. <-- Currently uses AppKitFullscreen API. This should
// eventually migrate to the Immersive Fullscreen API.
-//
-// TODO(erikchen): Remove this.
-// + Simplified fullscreen. Hidden by default. Some users have manually
-// enabled it.
-// - OMNIBOX_PRESENT. Can be with either fullscreen API.
// Methods having to do with fullscreen and presentation mode.
@interface BrowserWindowController(Fullscreen)
@@ -508,7 +500,7 @@ enum SlidingStyle {
- (void)enterPresentationModeForURL:(const GURL&)url
bubbleType:(FullscreenExitBubbleType)bubbleType;
-// Tries to enter presentation mode. Falls back to simplified fullscreen.
+// Tries to use AppKit Fullscreen, falls back to Immersive Fullscreen.
Robert Sesek 2014/09/02 14:19:33 I think we'll want to make this always use immersi
- (void)enterHTML5FullscreenForURL:(const GURL&)url
bubbleType:(FullscreenExitBubbleType)bubbleType;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698