Chromium Code Reviews Chromium Code Reviews
Issue 523153:
Make about:plugin page get rendered properly in Hebrew and Arabic Chrome.... (Closed)
Base URL: svn://chrome-svn/chrome/trunk/src/| Index: chrome/browser/resources/about_plugins.html |
| =================================================================== |
| --- chrome/browser/resources/about_plugins.html (revision 35468) |
| +++ chrome/browser/resources/about_plugins.html (working copy) |
| @@ -1,4 +1,7 @@ |
| <!DOCTYPE HTML> |
| +<html id="t" i18n-values="dir:textdirection;"> |
| +<head> |
| +<meta charset="utf-8"> |
| <!-- |
| A modified version of the about:plugins page found in Mozilla. The license of |
| @@ -46,14 +49,8 @@ |
| - |
| - ***** END LICENSE BLOCK ***** --> |
| -<html id="t"> |
| -<head> |
| <title jscontent="title"></title> |
| <style> |
| -body { |
| - font-family: sans-serif; |
| - font-size: 0.8em; |
| -} |
| div#outside { |
| text-align: justify; |
| @@ -82,22 +79,35 @@ |
| border-spacing: 0px; |
| } |
| +html[dir='rtl'] table { |
| + text-align: right; |
| +} |
| + |
| th { |
| text-align: center; |
| background-color: Highlight; |
| color: HighlightText; |
| } |
| -th + th, |
| -td + td { |
| +html[dir='ltr'] th + th, |
| +html[dir='ltr'] td + td { |
|
arv (Not doing code reviews)
2010/01/08 00:25:48
It is enough to only do the rtl ones.
th + th,
td
|
| border-left: 1px dotted ThreeDShadow; |
| } |
| +html[dir='rtl'] th + th, |
| +html[dir='rtl'] td + td { |
| + border-right: 1px dotted ThreeDShadow; |
| +} |
| + |
| td { |
| text-align: left; |
| border-top: 1px dotted ThreeDShadow; |
| } |
| +html[dir='rtl'] td { |
| + text-align: right; |
| +} |
| + |
| th, td { |
| padding: 3px; |
| } |
| @@ -115,7 +125,7 @@ |
| } |
| </style> |
| </head> |
| -<body> |
| +<body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> |
| <div id="outside"> |
| <script type="application/x-javascript"> |
