Make about:plugin page get rendered properly in Hebrew and Arabic Chrome....

chrome/browser/browser_about_handler.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_about_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "app/l10n_util.h"
@@ skipping 339 matching lines @@
       l10n_util::GetString(IDS_ABOUT_PLUGINS_DESCRIPTION_LABEL));
   localized_strings.SetString(L"suffixes",
       l10n_util::GetString(IDS_ABOUT_PLUGINS_SUFFIX_LABEL));
   localized_strings.SetString(L"enabled",
       l10n_util::GetString(IDS_ABOUT_PLUGINS_ENABLED_LABEL));
   localized_strings.SetString(L"enabled_yes",
       l10n_util::GetString(IDS_ABOUT_PLUGINS_ENABLED_YES));
   localized_strings.SetString(L"enabled_no",
       l10n_util::GetString(IDS_ABOUT_PLUGINS_ENABLED_NO));
 
+  ChromeURLDataManager::DataSource::SetFontAndTextDirection(&localized_strings);
+
   static const base::StringPiece plugins_html(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_ABOUT_PLUGINS_HTML));
 
-  return jstemplate_builder::GetTemplateHtml(
+  return jstemplate_builder::GetTemplatesHtml(
       plugins_html, &localized_strings, "t" /* template root node id */);
 }
 
 std::string AboutStats() {
   // We keep the DictionaryValue tree live so that we can do delta
   // stats computations across runs.
   static DictionaryValue root;
 
   StatsTable* table = StatsTable::current();
   if (!table)
@@ skipping 114 matching lines @@
 std::string AboutVersion(DictionaryValue* localized_strings) {
   localized_strings->SetString(L"title",
       l10n_util::GetString(IDS_ABOUT_VERSION_TITLE));
   scoped_ptr<FileVersionInfo> version_info(
       FileVersionInfo::CreateFileVersionInfoForCurrentModule());
   if (version_info == NULL) {
     DLOG(ERROR) << "Unable to create FileVersionInfo object";
     return std::string();
   }
 
-  std::wstring webkit_version = UTF8ToWide(webkit_glue::GetWebKitVersion());
+  std::string webkit_version = webkit_glue::GetWebKitVersion();
 #ifdef CHROME_V8
-  const char* v8_vers = v8::V8::GetVersion();
-  std::wstring js_version = UTF8ToWide(v8_vers);
-  std::wstring js_engine = L"V8";
+  std::string js_version(v8::V8::GetVersion());
+  std::string js_engine = "V8";
 #else
-  std::wstring js_version = webkit_version;
-  std::wstring js_engine = L"JavaScriptCore";
+  std::string js_version = webkit_version;
+  std::string js_engine = "JavaScriptCore";
 #endif
 
   localized_strings->SetString(L"name",
       l10n_util::GetString(IDS_PRODUCT_NAME));
   localized_strings->SetString(L"version", version_info->file_version());
   std::wstring mod = UTF16ToWide(platform_util::GetVersionStringModifier());
   localized_strings->SetString(L"version_modifier", mod);
   localized_strings->SetString(L"js_engine", js_engine);
   localized_strings->SetString(L"js_version", js_version);
   localized_strings->SetString(L"webkit_version", webkit_version);
   localized_strings->SetString(L"company",
       l10n_util::GetString(IDS_ABOUT_VERSION_COMPANY_NAME));
   localized_strings->SetString(L"copyright",
       l10n_util::GetString(IDS_ABOUT_VERSION_COPYRIGHT));
   localized_strings->SetString(L"cl", version_info->last_change());
   if (version_info->is_official_build()) {
     localized_strings->SetString(L"official",
       l10n_util::GetString(IDS_ABOUT_VERSION_OFFICIAL));
   } else {
     localized_strings->SetString(L"official",
       l10n_util::GetString(IDS_ABOUT_VERSION_UNOFFICIAL));
   }
-  localized_strings->SetString(L"useragent",
-      UTF8ToWide(webkit_glue::GetUserAgent(GURL())));
+  localized_strings->SetString(L"useragent", webkit_glue::GetUserAgent(GURL()));
 
   static const std::string version_html(
       ResourceBundle::GetSharedInstance().GetDataResource(
           IDR_ABOUT_VERSION_HTML));
 
-  std::string output = version_html;
-  jstemplate_builder::AppendJsonHtml(localized_strings, &output);
-  jstemplate_builder::AppendI18nTemplateSourceHtml(&output);
-  jstemplate_builder::AppendI18nTemplateProcessHtml(&output);
-  jstemplate_builder::AppendJsTemplateSourceHtml(&output);
-  jstemplate_builder::AppendJsTemplateProcessHtml("t", &output);
-  return output;
+  return jstemplate_builder::GetTemplatesHtml(

[arv (Not doing code reviews), 2010/01/08 00:25:48]

Actually, I would prefer if we kept it the old way and added a todo to stop
using JSTemplate for about_version.html since it is not needed there. The
I18nTemplate is much simpler and faster.

+      version_html, localized_strings, "t" /* template root node id */);
 }
 
 static void AddBoolSyncDetail(ListValue* details, const std::wstring& stat_name,
                               bool stat_value) {
   DictionaryValue* val = new DictionaryValue;
   val->SetString(L"stat_name", stat_name);
   val->SetBoolean(L"stat_value", stat_value);
   details->Append(val);
 }
 
@@ skipping 421 matching lines @@
     // Run the dialog. This will re-use the existing one if it's already up.
     AboutIPCDialog::RunDialog();
     return true;
   }
 #endif
 
 #endif  // OFFICIAL_BUILD
 
   return false;
 }