Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 523113003: Fail if retcode is not zero after push (Closed)

Created:
6 years, 3 months ago by iannucci
Modified:
6 years, 3 months ago
Reviewers:
dnj, Vadim Sh., agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Make git-cl-{dcommit,land} fail if retcode is not zero after push. R=dnj@chromium.org, vadimsh@chromium.org BUG=409170 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M git_cl.py View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
6 years, 3 months ago (2014-08-29 21:55:27 UTC) #1
dnj
lgtm
6 years, 3 months ago (2014-08-29 21:58:50 UTC) #2
agable
On 2014/08/29 21:58:50, dnj wrote: > lgtm lgtm
6 years, 3 months ago (2014-08-29 22:05:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/523113003/1
6 years, 3 months ago (2014-08-29 22:06:10 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 22:11:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 291745

Powered by Google App Engine
This is Rietveld 408576698