Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 523111: GTK: Refresh the visibliity of other download items when removing a download ... (Closed)

Created:
10 years, 11 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com, Paul Godavari, ben+cc_chromium.org
Visibility:
Public.

Description

GTK: Refresh the visibliity of other download items when removing a download item from the shelf. BUG=31612 TEST=1. navigate to cygwin.com 2. save page 3. make page just narrow enough to only hold a dangerous download dialog 4. click on the cygwin.exe link 5. discard 6. save page item should reappear Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/gtk/download_item_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
10 years, 11 months ago (2010-01-06 23:45:14 UTC) #1
Elliot Glaysher
10 years, 11 months ago (2010-01-06 23:52:40 UTC) #2
LGTM

On Wed, Jan 6, 2010 at 3:45 PM,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> GTK: Refresh the visibliity of other download items when removing a download
> item from the shelf.
>
> BUG=31612
> TEST=1. navigate to cygwin.com
> 2. save page
> 3. make page just narrow enough to only hold a dangerous download dialog
> 4. click on the cygwin.exe link
> 5. discard
> 6. save page item should reappear
>
>
> Please review this at http://codereview.chromium.org/523111
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/gtk/download_item_gtk.cc
>
>
> Index: chrome/browser/gtk/download_item_gtk.cc
> ===================================================================
> --- chrome/browser/gtk/download_item_gtk.cc     (revision 35400)
> +++ chrome/browser/gtk/download_item_gtk.cc     (working copy)
> @@ -340,6 +340,7 @@
>   get_download()->RemoveObserver(this);
>   g_signal_handlers_disconnect_by_func(parent_shelf_->GetHBox(),
>       reinterpret_cast<gpointer>(OnShelfResized), this);
> +  gtk_widget_show_all(parent_shelf_->GetHBox());
>
>   hbox_.Destroy();
>   progress_area_.Destroy();
>
>
>

Powered by Google App Engine
This is Rietveld 408576698