Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 523073003: Update libjingle's GN build config to match a recent fix. (Closed)

Created:
6 years, 3 months ago by tommi (sloooow) - chröme
Modified:
6 years, 3 months ago
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update libjingle's GN build config to match a recent fix. See here: https://codereview.chromium.org/516143002/ TBR=ajm Committed: https://crrev.com/d74e0b9e36ef8b296452b14546f8d4b63e07a94c Cr-Commit-Position: refs/heads/master@{#292792}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
tommi (sloooow) - chröme
6 years, 3 months ago (2014-08-30 15:34:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/523073003/1
6 years, 3 months ago (2014-08-30 15:35:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as ffeda845f7a30d7092ba6f988f98c701b0514432
6 years, 3 months ago (2014-08-30 16:33:41 UTC) #4
ajm
lgtm, thanks for fixing. +kjellander, brettw: there's a useful presubmit check for this in webrtc ...
6 years, 3 months ago (2014-08-30 16:46:57 UTC) #5
ajm
On 2014/08/30 16:46:57, ajm wrote: > lgtm, thanks for fixing. > > +kjellander, brettw: there's ...
6 years, 3 months ago (2014-08-30 16:47:33 UTC) #6
kjellander_chromium
I was actually looking at this particular problem recently since I noticed the Android GN ...
6 years, 3 months ago (2014-08-30 17:01:53 UTC) #8
kjellander_chromium
On 2014/08/30 16:46:57, ajm wrote: > lgtm, thanks for fixing. > > +kjellander, brettw: there's ...
6 years, 3 months ago (2014-08-30 17:02:56 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d74e0b9e36ef8b296452b14546f8d4b63e07a94c
Cr-Commit-Position: refs/heads/master@{#292792}

Powered by Google App Engine
This is Rietveld 408576698