Issue 523043004: [NaCl SDK] nacl_io: fix bionic build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 523043004: [NaCl SDK] nacl_io: fix bionic build (Closed)

Created:
6 years, 3 months ago by Sam Clegg

Modified:
6 years, 3 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NaCl SDK] nacl_io: fix bionic build getnameinfo has a slightly different signature on bionic. TEST=./build_tools/build_sdk.py --bionic Committed: https://crrev.com/08906d2ccfce56f719b060df9f8b9b781c25a44b Cr-Commit-Position: refs/heads/master@{#292725}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	native_client_sdk/src/libraries/nacl_io/syscalls/getnameinfo.c	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Committed patchset #1 (id:1) as e7d7deb73dc54e8cbded84600ff5bb8758117a71

6 years, 3 months ago (2014-08-30 00:04:16 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:12:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/08906d2ccfce56f719b060df9f8b9b781c25a44b
Cr-Commit-Position: refs/heads/master@{#292725}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages