Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 523023003: Remove "Search Google for this image" context menu item for <webview>. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove "Search Google for this image" context menu item for <webview>. The functionality was always broken, so remove it until it gets fixed. We already do not show Searh google for * keyword item anyway. BUG=407897 Test=In a chrome app, open a <webview> that loads an image. Right click on that image. "Search Google for this image" context menu item shouldn't appear. Committed: https://crrev.com/e19acc3f5cbe6b8fe48bf2505e142a11bc988d0d Cr-Commit-Position: refs/heads/master@{#292749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
lazyboy
6 years, 3 months ago (2014-08-29 22:51:34 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-08-29 23:11:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/523023003/1
6 years, 3 months ago (2014-08-29 23:15:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-30 01:04:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 42d7bd6b91bfb949a58534ef608464f9d753e86b
6 years, 3 months ago (2014-08-30 01:38:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:12:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e19acc3f5cbe6b8fe48bf2505e142a11bc988d0d
Cr-Commit-Position: refs/heads/master@{#292749}

Powered by Google App Engine
This is Rietveld 408576698